fix(installer): remove centos 7 and 8 repo due to eol #648
Conversation
| else | ||
| yum-config-manager --add-repo=http://mirror.centos.org/centos/8/extras/x86_64/os || true | ||
| $URLGET_CMD "https://www.centos.org/keys/RPM-GPG-KEY-CentOS-Official" > EXTRAS_KEY | ||
| fi | ||
| rpm --import EXTRAS_KEY |
There was a problem hiding this comment.
if we don't have something to set EXTRAS_KEY won't this fail?
There was a problem hiding this comment.
Good catch! I have updated code to remove the EXTRAS_KEY import part, since it will not be used, if we are not going to set the repos
| @@ -227,16 +227,6 @@ _installDocker() { | |||
| yum install -y yum-utils | |||
| logSuccess "Installed yum-utils" | |||
| fi | |||
| getUrlCmd | |||
There was a problem hiding this comment.
I think you can remove this entire block from line 220 as you do not need yum-utils if you are not going to use yum-config-manager.
One thing to note is that this assumes that appstream repo is enabled on rhel. I think it is best that the script fail if it is not but it may end in a support case and we need to instruct the customer to enable.
Installing:
container-selinux noarch 2:2.229.0-2.module+el8.10.0+21196+3f0abbca rhui-rhel-8-for-x86_64-appstream-rhui-rpms 71 k
I tested this on gcp with image rhel-8-v20240515 and it seemed to work.
There was a problem hiding this comment.
I also tested on azure since it is in the comment and that worked as well.
There was a problem hiding this comment.
Thank you @emosbaugh! I have removed the yum-utils install part
According to EOL notice
As a result, both http://mirror.centos.org/centos/7/extras/x86_64 and http://mirror.centos.org/centos/8/extras/x86_64/os are return 404 based on the EOL date.
Remove them for failing at the docker install step